Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installation of kernel-devel on Rocky 8 #2564

Merged
merged 3 commits into from
Nov 24, 2023

Conversation

jdeamicis
Copy link
Contributor

Description of changes

  • Use the --releasever option to make sure the repos from the same minor release as the currently running kernel are used when installing kernel-devel.
  • Install kernel-devel before installing the base packages to avoid dkms pulling kernel-devel from the wrong repos.

Tests

  • Manual run of kitchen tests;
  • Verified that the right version of kernel-devel is installed.

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Use the `--releasever` option to make sure the repos from the same
minor release as the currently running kernel are used when installing
kernel-devel.

Install kernel-devel before installing the base packages to avoid dkms
pulling kernel-devel from the wrong repos.

Signed-off-by: Jacopo De Amicis <[email protected]>
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5de32ac) 76.27% compared to head (b7b3ba6) 76.27%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2564   +/-   ##
========================================
  Coverage    76.27%   76.27%           
========================================
  Files           13       13           
  Lines         1901     1901           
========================================
  Hits          1450     1450           
  Misses         451      451           
Flag Coverage Δ
unittests 76.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdeamicis jdeamicis enabled auto-merge (rebase) November 23, 2023 18:56
@jdeamicis jdeamicis closed this Nov 23, 2023
auto-merge was automatically disabled November 23, 2023 21:30

Pull request was closed

@jdeamicis jdeamicis reopened this Nov 23, 2023
@jdeamicis jdeamicis enabled auto-merge (rebase) November 23, 2023 21:31
@jdeamicis jdeamicis force-pushed the wip/devel/fix_rocky_first_stage branch from 7de7ff8 to 98cfbed Compare November 24, 2023 00:48
@jdeamicis jdeamicis merged commit f55e31f into aws:develop Nov 24, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants