Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic to reset Slurm accounting password after queue update #2015

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

jdeamicis
Copy link
Contributor

Description of changes

Tests

  • Performed a manual run of:
    • schedulers/test_slurm_accounting.py::test_slurm_accounting
    • schedulers/test_slurm.py::test_slurm_config_update
    • update/test_update.py::test_update_instance_list

Checklist

  • Make sure you are pointing to the right branch and add a label in the PR title (i.e. 2.x vs 3.x)
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jdeamicis jdeamicis requested review from a team as code owners April 18, 2023 13:01
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #2015 (a5fd564) into develop (e70cff8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2015   +/-   ##
========================================
  Coverage    69.42%   69.42%           
========================================
  Files           12       12           
  Lines         1766     1766           
========================================
  Hits          1226     1226           
  Misses         540      540           
Flag Coverage Δ
unittests 69.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jdeamicis jdeamicis force-pushed the fix/devel/fix_slurm_accounting branch from f812dd2 to a5fd564 Compare April 18, 2023 13:22
@jdeamicis jdeamicis merged commit 8daa943 into aws:develop Apr 18, 2023
@jdeamicis jdeamicis deleted the fix/devel/fix_slurm_accounting branch April 18, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants