Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Slurm accounting password being overridden at queue update #2006

Merged
merged 3 commits into from
Apr 17, 2023

Conversation

jdeamicis
Copy link
Contributor

@jdeamicis jdeamicis commented Apr 13, 2023

Description of changes

Tests

References

Checklist

  • Make sure you are pointing to the right branch and add a label in the PR title (i.e. 2.x vs 3.x)
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jdeamicis jdeamicis added the 3.x label Apr 13, 2023
@jdeamicis jdeamicis requested review from a team as code owners April 13, 2023 17:47
@jdeamicis jdeamicis marked this pull request as draft April 13, 2023 17:47
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #2006 (c0acd9c) into develop (709565b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2006   +/-   ##
========================================
  Coverage    69.42%   69.42%           
========================================
  Files           12       12           
  Lines         1766     1766           
========================================
  Hits          1226     1226           
  Misses         540      540           
Flag Coverage Δ
unittests 69.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

NSsirena
NSsirena previously approved these changes Apr 14, 2023
@jdeamicis jdeamicis force-pushed the fix/devel/fix_slurm_accounting_new branch from 48ea595 to dbdbaef Compare April 17, 2023 08:57
Fix a bug that caused the slurmdbd database password to be overridden
during a cluster update where the queues were being updated and the
Slurm accounting configuration was not being modified.

Signed-off-by: Jacopo De Amicis <[email protected]>
Signed-off-by: Jacopo De Amicis <[email protected]>
@jdeamicis jdeamicis force-pushed the fix/devel/fix_slurm_accounting_new branch from dbdbaef to c0acd9c Compare April 17, 2023 09:03
@jdeamicis jdeamicis merged commit 450da98 into aws:develop Apr 17, 2023
@jdeamicis jdeamicis deleted the fix/devel/fix_slurm_accounting_new branch April 17, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants