Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/observability/opentelemetry.go does not have unit test #1088

Closed
phuhung273 opened this issue Nov 23, 2024 · 1 comment
Closed

pkg/observability/opentelemetry.go does not have unit test #1088

phuhung273 opened this issue Nov 23, 2024 · 1 comment
Assignees
@tiationg-kho

Comments

@phuhung273
Copy link

Describe the feature
pkg/observability/opentelemetry.go does not have unit test

Is the feature request related to a problem?
Im working on #1083. This requires some changes in pkg/observability/opentelemetry.go but it doesn't have any unit test. Make contributors less confident.

As discussed, better to have a separate PR to refactor pkg/observability/opentelemetry.go to be testable before any further change
@tiationg-kho tiationg-kho self-assigned this Nov 26, 2024
tiationg-kho added a commit to tiationg-kho/aws-node-termination-handler that referenced this issue Nov 28, 2024
@tiationg-kho
Disable prometheus port when not allowed (aws#1078) and add unit test…
c6bd492 
… for opentelemetry (aws#1088)
@tiationg-kho tiationg-kho mentioned this issue Nov 28, 2024
Merged
tiationg-kho added a commit that referenced this issue Dec 5, 2024
@tiationg-kho
Fix prometheus port and add unit test for opentelemetry (#1093)
1a0643c 
* Disable prometheus port when not allowed (#1078) and add unit test for opentelemetry (#1088)
@tiationg-kho
Copy link
Contributor

Solved in latest release. Please let us know if there is any other issue. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tiationg-kho tiationg-kho

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phuhung273 @tiationg-kho