Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aws-node-termination-handler helm chart is trying to hit /metrics endpoint even after setting enable-prometheus-server as false. #1078

Closed
BIPLAVGHOSAL opened this issue Oct 16, 2024 · 2 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@BIPLAVGHOSAL
Copy link

Describe the bug
Deployed the aws-node-termination-handler Helm chart successfully in EKS cluster, with node-termination-arguments as

enable-prometheus-server: false,
prometheus-server-port: 8080,

The Helm chart status is deployed and upon checkin the pod logs, found that it is trying to hit the /metrics endpoint for Prometheus and this gives 404 logs in the pod level.

can you please suggest after setting the enable-prometheus-server argument as false why it is trying to reach for the server endpoint ?

Steps to reproduce

Expected outcome

  • When the argument enable-prometheus-server: false, is set as false it should not automatically try to hit /metrics endpoint.

Application Logs

image

Environment

  • NTH App Version:
  • NTH Mode (IMDS/Queue processor):
  • OS/Arch: Linux
  • Kubernetes version: 1.29
  • Installation method: Helm chart update via Terraform.
  • Helm Chart appVersion : v1.22.1
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want this issue to never become stale, please ask a maintainer to apply the "stalebot-ignore" label.

@github-actions github-actions bot added the stale Issues / PRs with no activity label Nov 15, 2024
@LikithaVemulapalli LikithaVemulapalli added good first issue Good for newcomers and removed stale Issues / PRs with no activity labels Nov 18, 2024
tiationg-kho added a commit to tiationg-kho/aws-node-termination-handler that referenced this issue Nov 28, 2024
tiationg-kho added a commit that referenced this issue Dec 5, 2024
* Disable prometheus port when not allowed (#1078) and add unit test for opentelemetry (#1088)
@tiationg-kho
Copy link
Contributor

Solved in latest release. Please let us know if there is any other issue. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants