Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic GH CI build/test with full range of gcc/clang #1546

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Apr 23, 2024

Description of changes:

  • Adds basic CI build/test with all GH available GCC/Clang compilers on Ubuntu.

Call-outs:

  • This a supplement to the more exhaustive testing done in CodeBuild for many (but not all) of the same compilers.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth force-pushed the ci-gcc-13 branch 5 times, most recently from b098663 to 358a779 Compare April 23, 2024 17:40
@samuel40791765
Copy link
Contributor

My understanding was that we used Codebuild for basic tests on linux with different versions of gcc/clang. Did we want to introduce another gcc test dimension via Github Actions?

@justsmth justsmth changed the title [DRAFT] CI test with GCC 12/13 [DRAFT] Basic GH CI build/test with full range of gcc/clang Apr 23, 2024
@justsmth justsmth marked this pull request as ready for review April 23, 2024 20:33
@justsmth justsmth requested a review from a team as a code owner April 23, 2024 20:33
@justsmth justsmth changed the title [DRAFT] Basic GH CI build/test with full range of gcc/clang Basic GH CI build/test with full range of gcc/clang Apr 23, 2024
Copy link
Contributor

@samuel40791765 samuel40791765 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We synced up on how we plan to use GHA for compiler tests on linux. The plan is to use GHA for basic sanity tests on different compilers and continue using Codebuild for more exhaustive tests on different compilers.
Ideally we would use succeeding the sanity test in GHA to kick off the exhaustive tests in Codebuild. But this would need more rewriting of the existing cdk script and it's unknown if Codebuild supports being started off a successful Github Actions run.

@justsmth justsmth merged commit 311ca38 into aws:main Apr 25, 2024
71 checks passed
@justsmth justsmth deleted the ci-gcc-13 branch April 25, 2024 13:30
skmcgrail added a commit that referenced this pull request May 2, 2024
d52018b Minor functions to build with Ruby's cipher module (#1564)
364d28b Changed SSL_client_hello_get0_ciphers to align with OpenSSL
behavior (#1542)
e8eb7de ppc64le: EVP_has_aes_hardware is false w/ no-asm (#1566)
d726d06 OpenBSD 7.4 and 7.5 Support (#1437)
a66c66e Remove comments about overread for entropy generation (#1551)
f8a575f Migrate from __FreeBSD__ to __FreeBSD_version (#1562)
c31d1ce Centralize handling of s2n-bignum alt/non-alt function
selection (#1547)
00f3c45 CI for other MacOS versions (#1558)
0541314 Cleanup remaing duplicate symbol definitions and turn
Wredundant-decls on (#1561)
4d280eb Fix ec2 CI testing framework (#1541)
9a4b43e Update x25519_test.cc array initialization to avoid a bug with
a GCC 13 warning (#1555)
388cbe7 Remove duplicate X509_OBJECT_new and X509_OBJECT_free
declarations (#1560)
2ea6706 Avoid 'z' format with MSVCRT (#1559)
c25dc2a Add dependency to python3-six in github action grpc (#1554)
2bdcba3 Link porting guide table to header documentation (#1540)
311ca38 Basic GH CI build/test with full range of gcc/clang (#1546)
1f19717 Add SHA3-256 KAT to FIPS self-test (#1549)
0f3548a Add EC point add/dbl to speed.cc (#1545)
d7ddfc4 Fix the NTP integration test (NTP website changed) (#1548)
8ccd85b Fix skipped tests in Mariadb integration CI (#1533)
d940162 Support vpinsrq in delocater (#1543)
4cd6d21 Remove redundant test exec libraries (#1544)
56f3569 [ML-KEM] Add experimental support for ML-KEM-512-IPD (#1516)
c295aef Upstream merge 2024 04 16 (#1535)
2e51629 Re-add function
0aebf17 Define OPENSSL_NO_TLS_PHA, typedef PSK callback signatures
(#1526)
46056cf Pull the string-based extensions APIs into their own section
960ea42 Unexport X509_VERIFY_PARAM_lookup
3c597b1 Remove X509_VERIFY_PARAM_get0_peername
9c399e5 Document some key usage accessors
2fe70b5 Simplify and document X509_supported_extension
2e04897 Const-correct X509_LOOKUP_METHOD
9826568 Replace X509_LOOKUP_ctrl with real functions
e47c056 Tidy up x509_lu.c functions a little
62e019f Clean up the by_file_ctrl x509 code to be slightly less obtuse
45c46c2 Use relative links in markdown files

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and the ISC license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants