Remove 'gimme' tool and -devel packages from build toolchain #875
+15
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead use official public ECR golang images. Also remove unecessary "-devel" packages in main-release image. Fixes #368
|
Covered by the testing, and conceptually we've approved this change in #868, which looks identical aside from the removed We'll need to wait until 2.32.4 is upgraded to stable before merging this change, though, to avoid introducing a latest/stable mismatch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Instead use official public ECR golang images.
Also remove unecessary "-devel" packages in main-release image.
Fixes #368
This is a re-attempt of #868, except this time only remove devel packages from the "main release base" image, leave them in the build image. And this time I've also run
make debug.Issue #, if available: 368
Testing
make debugsucceeded: yesInteg tests succeeded: yes
New tests cover the changes: no
Description for the changelog
Remove 'gimme' build tool, remove some -devel packages from release base image
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.