Remove 'gimme' tool and -devel packages from build toolchain #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead use official public ECR golang images. Also remove unecessary "-devel" packages in build and release images. Fixes #368
swapneils
requested changes
Oct 14, 2024
There was a problem hiding this comment.
I don't think our tests fully cover the golang versions of AWS plugins.
Could you also change the integ test code to use cloudwatch / kinesis / firehose instead of cloudwatch_logs / kinesis_streams / kinesis_firehose and run with those changes, so we know this change doesn't impact these plugins?
|
Nvm, I misread our test setup previously. This should be good to merge. |
swapneils
approved these changes
Oct 14, 2024
swapneils
pushed a commit
to swapneils/aws-for-fluent-bit
that referenced
this pull request
Oct 23, 2024
swapneils
pushed a commit
to swapneils/aws-for-fluent-bit
that referenced
this pull request
Oct 23, 2024
swapneils
added a commit
that referenced
this pull request
Oct 23, 2024
#871) * Revert "Remove 'gimme' tool and -devel packages from build toolchain (#868)" This reverts commit d78beaf. * Add make and integ test steps to the PR template * Fix local testing link in PR template and README * Re-release 2.32.3 (no-op) Adding this change so the commit history clearly indicates the contents of 2.32.3 --------- Co-authored-by: Swapneil Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Instead of "gimme" use official public ECR golang images.
Also remove unecessary "-devel" packages in build and release images.
Issue #, if available: Fixes #368
Testing
All integ tests were run
New tests cover the changes: no
Description for the changelog
NA
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.