Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump dafnyVerifyVersion to 4.7.0 #488

Merged
merged 4 commits into from
Jul 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions AwsCryptographyPrimitives/test/TestECDH.dfy
Original file line number Diff line number Diff line change
Expand Up @@ -357,14 +357,15 @@ module TestECDH {
}
}

method {:test} TestCompressDecompressConstantPublicKeys() {
method {:test} {:vcs_split_on_every_assert} TestCompressDecompressConstantPublicKeys() {
var derX509PublicKeys := [ECC_P256_PUBLIC, ECC_384_PUBLIC, ECC_P521_PUBLIC];
var curves := [P256, P384, P521];
for i := 0 to |curves|
{
var curve := curves[i];
var originalPublicKey := derX509PublicKeys[i];
var publicKeyBytes := HexStrings.FromHexString(originalPublicKey);
var hexPublicKey := expectLooseHexString(originalPublicKey);
var publicKeyBytes := HexStrings.FromHexString(hexPublicKey);

var compressedPublicKeyResult :- expect ECDH.CompressPublicKey(
Types.CompressPublicKeyInput(
Expand Down
2 changes: 1 addition & 1 deletion project.properties
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@
# The Java project include this file as a Gradle properties
# And the Dotnet projects include and parse this file.
dafnyVersion=4.2.0
dafnyVerifyVersion=4.2.0
dafnyVerifyVersion=4.7.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI, I've had to add support to smithy-dafny to generate these project.properties files in order for the nightly builds to be able to use a newer Dafny everywhere. It isn't yet outputting this property, so that means the nightly builds are no longer verifying with the latest Dafny master.

The good news is this change helps close that gap, but it still exists and we should track it somehow.

Loading