Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump dafnyVerifyVersion to 4.7.0 #488

Merged
merged 4 commits into from
Jul 9, 2024

Conversation

josecorella
Copy link
Contributor

Issue #, if available:

Description of changes:

Squash/merge commit message, if applicable:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@josecorella josecorella requested a review from a team as a code owner July 8, 2024 20:28
Copy link
Contributor

@texastony texastony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josecorella You may want to check with @robin-aws , but maybe we should add new codegen patches for 4.7?

@josecorella
Copy link
Contributor Author

I will, this is baby steps though

@josecorella
Copy link
Contributor Author

I clicked on create instead of draft

dafnyVerifyVersion=4.2.0
dafnyVerifyVersion=4.7.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI, I've had to add support to smithy-dafny to generate these project.properties files in order for the nightly builds to be able to use a newer Dafny everywhere. It isn't yet outputting this property, so that means the nightly builds are no longer verifying with the latest Dafny master.

The good news is this change helps close that gap, but it still exists and we should track it somehow.

@robin-aws
Copy link
Contributor

You may want to check with @robin-aws , but maybe we should add new codegen patches for 4.7?

No need, this is why the codegen patches apply for any Dafny version at or above the version in their name.

@josecorella josecorella merged commit 874a188 into dafny-47 Jul 9, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants