Update v2 to use pyproject.toml #7287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v2 #7287 +/- ##
==========================================
+ Coverage 93.70% 93.71% +0.01%
==========================================
Files 351 351
Lines 36171 36171
Branches 5202 5202
==========================================
+ Hits 33895 33899 +4
+ Misses 1652 1648 -4
Partials 624 624
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kyleknap
reviewed
Sep 21, 2022
stealthycoin
force-pushed
the
pyproject
branch
7 times, most recently
from
562f5c1 to
b4d17d8
Compare
kyleknap
reviewed
Sep 26, 2022
kyleknap
reviewed
Sep 26, 2022
kyleknap
reviewed
Sep 26, 2022
kyleknap
reviewed
Sep 27, 2022
There was a problem hiding this comment.
Nice. This looks good. I just had a few more comments. It would also be good if we can expand in the PR description why we chose flit explicitly over setuptools and the benefits we get. Also feel free to squash all of the commits to what the final commit will be.
This change removes both the setup.py and setup.cfg files in favor of using the pyproject.toml. In addition we remove our build dependencies on both seuptools and wheel, instead using flit as our build backend.
stealthycoin
force-pushed
the
pyproject
branch
from
2945137 to
d4fae65
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to consolidate our build tooling around pyproject.toml. We were running into issues finding a version of setuptools that would work on python 3.8 through 3.10 for the sdist building PR: #7262. We decided to take the opportunity to move away from using setuptools entirely and to re-write our build tooling around flit, while at the same time moving from setup.py/setup.cfg fully over to pyproject.toml.
Setuptools has a lot of legacy functionality, and is constantly deprecating old behaviors and evolving. Because of this it has been the cause of a lot of issues for us in the past as behavior changes out from under us. Flit is new and very minimal. Our goal in the change is to have a stable core to our build system that we won't have to build around so defensively.