feat(custom-resources): make physical resource id optional (provider framework) #4946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…framework) In order to make it easier to get started and implement custom resources that do not require changes to physical resource IDs, the provider framework now allows `onEvent` to omit the `PhysicalResourceId` return value. For `CREATE` operations, it will default to the `RequestId`. For `UPDATE` and `DELETE` it will return the current `PhysicalResourceId`. Misc: in aws-custom-resource, use `fs.readFileSync(__dirname)` instead of `require` to load `sdk-api-metadata.json`, so that the typescript compiler won't yell that this file is not defined in tsconfig.json.
|
Thanks so much for taking the time to contribute to the AWS CDK ❤️ We will shortly assign someone to review this pull request and help get it
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
packages/@aws-cdk/custom-resources/lib/aws-custom-resource/aws-custom-resource.ts
Show resolved
Hide resolved
packages/@aws-cdk/custom-resources/lib/provider-framework/runtime/framework.ts
Show resolved
Hide resolved
.../custom-resources/test/provider-framework/integration-test-fixtures/s3-file-handler/index.ts
Show resolved
Hide resolved
.../custom-resources/test/provider-framework/integration-test-fixtures/s3-file-handler/index.ts
Show resolved
Hide resolved
rix0rrr
approved these changes
Nov 11, 2019
RomainMuller
approved these changes
Nov 11, 2019
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Without it the bin is not hoisted to `node_modules/.bin` and cannot be called from individual package directories.
Fix the Mergify operator for author condition. The current value for `author` is meant to be a regexp so the `~=` operator must be used to match it, not just `=`.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make it easier to get started and implement custom resources that do not require changes to physical resource IDs, the provider framework now allows
onEventto omit thePhysicalResourceIdreturn value.For
CREATEoperations, it will default to theRequestId. ForUPDATEandDELETEit will return the currentPhysicalResourceId.Misc: in aws-custom-resource, use
fs.readFileSync(__dirname)instead ofrequireto loadsdk-api-metadata.json, so that the typescript compiler won't yell that this file is not defined in tsconfig.json.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license