Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow adding additional files to tsconfig #965

Closed
eladb opened this issue Nov 11, 2019 · 5 comments
Closed

allow adding additional files to tsconfig #965

eladb opened this issue Nov 11, 2019 · 5 comments
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@eladb
Copy link
Contributor

eladb commented Nov 11, 2019

Maybe we should add a feature request to jsii to support adding files to the includes clause... We already support injecting exclude clauses......

Originally posted by @RomainMuller in aws/aws-cdk#4946
@eladb eladb mentioned this issue Nov 11, 2019
Merged
@SomayaB SomayaB added the feature-request A feature should be added or improved. label Nov 18, 2019
@RomainMuller RomainMuller added the effort/small Small work item – less than a day of effort label Jan 24, 2020
@RomainMuller
Copy link
Contributor

I think I would rather handle it in allowing users to basically won and control the tsconfig.json file and simply ensure they're compatible with jsii requirements...

@zxkane
Copy link

zxkane commented Apr 16, 2021

This issue has been inactive for a while, any plan to implement it. #1644 #2071 also requires this feature.

It’s a blocking issue for below scenario,

The library has some static assets not ending with .ts extension, the hardcode include in tsconfig can not package them to output folder.

@RomainMuller RomainMuller removed their assignment Jun 24, 2021
@echeung-amzn echeung-amzn mentioned this issue Feb 25, 2022
Closed
@nickehunt-idm
Copy link

See my updated issue on this, any progress / options for this?

@mrgrain
Copy link
Contributor

mrgrain commented May 21, 2024 •
edited
Loading

Closed in favor of user-provided tsconfigs #2071

Documentation:
https://aws.github.io/jsii/user-guides/lib-author/configuration/#typescript-configuration

@mrgrain mrgrain closed this as not planned Won't fix, can't repro, duplicate, stale May 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@mrgrain @RomainMuller @eladb @zxkane @SomayaB @nickehunt-idm