chore(release): 2.98.0 #27294

aws-cdk-automation · 2023-09-26T13:24:23Z

This change halves the load time of `require('aws-cdk-lib')`, from ~600ms to ~300ms on my machine. It also shaves ~8min off running all integ tests (again, on my machine). It does this by making all loading of JavaScript modules lazy, so they are only loaded just before any symbols from them are actually accessed (instead of loading all modules at startup). This new automatic module replaces the previous manual effort to do something similar, in `lazy-index.ts`. Note that this transformation (unfortunately) does not affect TypeScript compilation times: the TypeScript compiler is still going to read all `.d.ts` files. To improve interactive TypeScript performance, use `swc` or `ts-node` with type checking disabled. Fully type checking your application using `tsc` will take the amount of time it takes. ## What's the big idea? Turning this: ```js const x = require("x"); module.exports.banana = function() { return x.hello(); } ``` Into this: ```js var x = () => { var tmp = require("x"); x = () => tmp; return tmp; }; module.exports.banana = function () { return x().hello(); }; ``` ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Small change to make it possible to disable a Schedule. It basically works the same as in Rule in aws-events. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Various fixes to awslint. Also adds new exclusions to prevent existing lint errors from failing the build - will address these errors in a follow-up. Linter config, including exclusions, has been moved into a new file `awslint.json`. If this file does not exist, the linter will continue reading and updating the config in `package.json`. Fixes #26839. Linter changes: - Include symbols from submodules by using e.g. `assembly.allClasses` instead of `assembly.classes` - Fix FQNs in the construct linter by including the submodule name - Use `cloudformationResource` tag (added in cdklabs/awscdk-service-spec#538) to store CFN resource ID when generating L1 constructs. This is used in the CFN resource linter. - Fix `core-types.ts` to use new package names - Ignore version suffixes when guessing resource names in `packages/awslint/lib/rules/resource.ts` The change in `aws-apigateway/lib/resource.ts` is an example of a `props-physical-name` fix. Breakdown of new linter errors: ``` docs-public-apis: 2308 props-default-doc: 214 props-physical-name: 106 attribute-tag: 13 construct-interface-extends-iconstruct: 8 resource-interface-extends-resource: 8 from-method: 8 props-no-cfn-types: 7 ref-via-interface: 5 from-signature: 4 construct-ctor-props-optional: 3 props-no-arn-refs: 3 props-no-any: 2 integ-return-type: 2 module-name: 1 construct-ctor: 1 props-struct-name: 1 construct-ctor-props-type: 1 no-static-import: 1 public-static-props-all-caps: 1 Total: 2697 ``` ### Tasks - [x] Push cdklabs/awscdk-service-spec#538 before merging *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

See [CHANGELOG](https://github.com/aws/aws-cdk/blob/merge-back/2.97.0/CHANGELOG.md)

…est (#27257) init-javascript.integtest.js is failing in the main pipeline with the following error: ``` Error: Cannot find module '/tmp/cdk-integ-0iwta1unfroo/new-entrypoing.mjs' ``` This PR fixes this by correcting the spelling of `new-entrypoing` to `new-entrypoint` ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Reported by GitHub's code quality scanning tool. Many of these are problems with regular expressions. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

FEATURE_FLAGS.md is not updated so updated it with rebuild. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

…7273) Previously a type from a submodule with a FQN like `aws_service.CfnTheResource.SubType` was not identified as an L1 type, and subjected to stricter L2 rules. Fixes failing integration tests in https://github.com/cdklabs/awscdk-service-spec E.g. https://github.com/cdklabs/awscdk-service-spec/actions/runs/6293221129/job/17097529390 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

With this, GitHub will not show them by default in diffs. The diff can still be viewed, but only on request. Tested on this PR: https://github.com/aws/aws-cdk/pull/27278/files ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

AWS Service Spec packages to latest versions.

…tabase cluster from a snapshot (under feature flag) (#27174) This PR fixes a bug where an extra database secret is being generated when an RDS database cluster is being created from a snapshot. On the `DatabaseClusterFromSnapshotProps` interface, we deprecated the `credentials` property and, at the same, introduced `snapshotCredentials` as the recommended replacement. However, the default behavior associated with the `credentials` property was not removed as doing so would introduce a breaking change for some users as detailed in this [PR](#20777). As a result, users just using the recommended `snapshotCredentials` property to create a new RDS database cluster are seeing an extra, unwanted secret being created. Closes #23815 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Closes #27281. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Reverts #27105 This fixes #27259 by reverting the offending commit.

See [CHANGELOG](https://github.com/aws/aws-cdk/blob/merge-back/2.97.1/CHANGELOG.md)

CHANGELOG.v2.md

aws-cdk-automation · 2023-09-26T14:32:24Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: e12f8ed
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2023-09-26T14:32:43Z

Thank you for contributing! Your pull request will be automatically updated and merged without squashing (do not update manually, and be sure to allow changes to be pushed to your fork).

rix0rrr and others added 18 commits September 22, 2023 15:02

feat(scheduler): disable Schedule on creation (#27236)

193cd3f

Small change to make it possible to disable a Schedule. It basically works the same as in Rule in aws-events. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Merge branch 'main' into merge-back/2.97.0

78a0106

chore(merge-back): 2.97.0 (#27254)

42494f1

See [CHANGELOG](https://github.com/aws/aws-cdk/blob/merge-back/2.97.0/CHANGELOG.md)

chore: address a number of CodeQL errors (#27253)

7d0f32f

Reported by GitHub's code quality scanning tool. Many of these are problems with regular expressions. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

docs(core): update FEATURE_FLAGS.md (#27269)

4ade7dc

FEATURE_FLAGS.md is not updated so updated it with rebuild. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

feat: update AWS Service Spec (#27276)

3d9ca8d

AWS Service Spec packages to latest versions.

docs: fix typo (#27282)

7670bd1

Closes #27281. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

revert: "feat(core): Schedule class" (#27284)

252d9ba

Reverts #27105 This fixes #27259 by reverting the offending commit.

Merge branch 'main' into merge-back/2.97.1

a5ceeb3

chore(merge-back): 2.97.1 (#27291)

3196733

See [CHANGELOG](https://github.com/aws/aws-cdk/blob/merge-back/2.97.1/CHANGELOG.md)

chore(release): 2.98.0

044b57c

aws-cdk-automation added auto-approve pr/no-squash This PR should be merged instead of squash-merging it labels Sep 26, 2023

aws-cdk-automation requested a review from a team September 26, 2023 13:24

github-actions bot approved these changes Sep 26, 2023

View reviewed changes

github-actions bot added the p2 label Sep 26, 2023

github-actions bot approved these changes Sep 26, 2023

View reviewed changes

aws-cdk-automation had a problem deploying to test-pipeline September 26, 2023 13:25 — with GitHub Actions Failure

kaizencc reviewed Sep 26, 2023

View reviewed changes

CHANGELOG.v2.md Outdated Show resolved Hide resolved

Update CHANGELOG.v2.md

e12f8ed

kaizencc had a problem deploying to test-pipeline September 26, 2023 13:57 — with GitHub Actions Failure

mergify bot merged commit b04f852 into v2-release Sep 26, 2023
13 of 14 checks passed

mergify bot deleted the bump/2.98.0 branch September 26, 2023 14:32

github-actions bot mentioned this pull request Oct 1, 2023

Monthly PRs metrics report - Sep 2023 #27368

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(release): 2.98.0 #27294

chore(release): 2.98.0 #27294

aws-cdk-automation commented Sep 26, 2023 •

edited

Loading

aws-cdk-automation commented Sep 26, 2023

mergify bot commented Sep 26, 2023

chore(release): 2.98.0 #27294

chore(release): 2.98.0 #27294

Conversation

aws-cdk-automation commented Sep 26, 2023 • edited Loading

aws-cdk-automation commented Sep 26, 2023

AWS CodeBuild CI Report

mergify bot commented Sep 26, 2023

aws-cdk-automation commented Sep 26, 2023 •

edited

Loading