build(awslint): include types from submodules during linting

[mikewrighton]

Various fixes to awslint. Also adds new exclusions to prevent existing lint errors from failing the build - will address these errors in a follow-up. Linter config, including exclusions, has been moved into a new file awslint.json. If this file does not exist, the linter will continue reading and updating the config in package.json. Fixes #26839.

Linter changes:

• Include symbols from submodules by using e.g. assembly.allClasses instead of assembly.classes
• Fix FQNs in the construct linter by including the submodule name
• Use cloudformationResource tag (added in feat(typewriter): Add docTags map to DocsSpec interface. cdklabs/awscdk-service-spec#538) to store CFN resource ID when generating L1 constructs. This is used in the CFN resource linter.
• Fix core-types.ts to use new package names
• Ignore version suffixes when guessing resource names in packages/awslint/lib/rules/resource.ts

The change in aws-apigateway/lib/resource.ts is an example of a props-physical-name fix.

Breakdown of new linter errors:

docs-public-apis: 2308
props-default-doc: 214
props-physical-name: 106
attribute-tag: 13
construct-interface-extends-iconstruct: 8
resource-interface-extends-resource: 8
from-method: 8
props-no-cfn-types: 7
ref-via-interface: 5
from-signature: 4
construct-ctor-props-optional: 3
props-no-arn-refs: 3
props-no-any: 2
integ-return-type: 2
module-name: 1
construct-ctor: 1
props-struct-name: 1
construct-ctor-props-type: 1
no-static-import: 1
public-static-props-all-caps: 1
Total: 2697

Tasks

• Push feat(typewriter): Add docTags map to DocsSpec interface. cdklabs/awscdk-service-spec#538 before merging

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[kaizencc]

everything else looks good to me!

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[rix0rrr]

Conditional approval

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: d80af5c
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).