Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(redshift-alpha): incorrect CR runtime version #26406

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

MrArnoldPalmer
Copy link
Contributor

Fixes the database-query custom resource in redshift alpha to correctly use Node18 as the runtime version since it now uses sdk v3.

Fixes: #26397


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Fixes the database-query custom resource in redshift alpha to correctly
use Node18 as the runtime version since it now uses sdk v3.

Fixes: #26397
@aws-cdk-automation aws-cdk-automation requested a review from a team July 18, 2023 16:55
@github-actions github-actions bot added the p2 label Jul 18, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 18, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@MrArnoldPalmer MrArnoldPalmer added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Jul 18, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review July 18, 2023 17:19

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: d4f4341
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jul 18, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit c8d8421 into main Jul 18, 2023
14 of 16 checks passed
@mergify mergify bot deleted the fix/redshift-cr-runtime branch July 18, 2023 17:21
bmoffatt pushed a commit to bmoffatt/aws-cdk that referenced this pull request Jul 29, 2023
Fixes the database-query custom resource in redshift alpha to correctly use Node18 as the runtime version since it now uses sdk v3.

Fixes: aws#26397

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@aws-cdk/aws-redshift-alpha: Custom resource unable to find AWS SDK v3
3 participants