-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
‼️ NOTICE custom-resources: various custom resources may fail to deploy / destroy #26325
Comments
I've made some changes to get the tests working again, but getting framework-integ directory to consistently apply these changes is difficult for some reason. There's an additional problem manifesting in the kubernetes-dashboard component of the cluster test that I couldn't iron out. I've removed that assertion as it's duplicative of the namespace test if we're just trying to demonstrate that |
Thank you for the report. Can you clarify which integ tests are failing? |
Here are a few:
The |
onDelete for the cluster handler returns a response without the
|
I think I'm close to being able to open a PR to fix this, but I'm having to completely strip out the nginx helm charts from the tests due to some breaking changes that were recently released. kubernetes-dashboard needs a complete rewire in the tests, but I really wonder how sustainable this model is. We could anchor to a specific version, I guess, but at the end of the day we've got a snapshot test with mutable dependencies.
|
@MrArnoldPalmer fyi |
Upgrade severity since this does not only effect integration tests but also real deployments. |
Ran npm-check-updates and yarn upgrade to keep the `yarn.lock` file up-to-date. Fixes #26325
|
Keep open until release is out. |
Ran npm-check-updates and yarn upgrade to keep the `yarn.lock` file up-to-date. Fixes aws#26325
|
Is this related?
I can open a separate issue for this if not, but I'm seeing seeing this all of a sudden and can't figure out why |
Could be! Please open a separate issue and we will start investigating. |
Status: In-Progress
What is the issue?
In #26212, we upgraded our NodeJS runtime to Node18, which meant all our custom resources now needed to operate on AWS SDK for JavaScript v3. There were a few places that we missed:
Who is affected?
Users of aws-cdk-lib version 2.87.0
How do I resolve this?
Upgrade to a version higher than 2.87.0
Workaround
No workaround
Original posting
Describe the bug
When running the integration tests for aws-eks or aws-stepfunctions-tasks where the cluster-resource-handler is invoked will result in a failure when onDelete is called. This is because the key
code
which is caught during the exception no longer exists. Fargate's handler is similarly affected.Expected Behavior
When calling the integration tests I expected the clusters to successfully create, update, and delete themselves.
Current Behavior
The final step of deleting the cluster fails with:
The cluster itself is deleting, but our evaluation of the result is failing, and thus is being treated as a failure.
Reproduction Steps
Check out the most recent build of
aws-cdk
and run any eks test which includes a fargate profile (e.g. integ.eks-cluster-ipv6)Possible Solution
We can change the current evaluation to use
$e.metadata.httpResponseCode === 404
instead of a string evaluation against the message.Additional Information/Context
There's a bunch of other stuff that's broken in the eks tests, especially with the helm chart for the kubernetes-dashboard. I've been working on a fix for the better part of 3 days and still haven't hit the bottom of the breakage.
This is affecting three tests in aws-stepfunctions-tasks.
I believe these failures are related to #26212 but I haven't had the time to identify the exact changes. The upgrade from aws-sdk-js v2 to v3 would have ideally triggered a re-run of all of the integration tests which use the SDK, but I don't believe the resource trees can see that difference.
CDK CLI Version
0.0.0 (build c38e784) (npx cdk)
2.42.0 (build 7d8ef0b) (local install)
Framework Version
No response
Node.js Version
v18.16.0
OS
MacOS 13.4
Language
Typescript
Language Version
No response
Other information
No response
The text was updated successfully, but these errors were encountered: