Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pipelines): reuseCrossRegionSupportStacks=true does not fail when existing pipeline is used #20423

Merged
merged 5 commits into from
Jul 14, 2022
Merged

fix(pipelines): reuseCrossRegionSupportStacks=true does not fail when existing pipeline is used #20423

merged 5 commits into from
Jul 14, 2022

Conversation

tejasmr
Copy link
Contributor

@tejasmr tejasmr commented May 19, 2022


Added prop check for reuseCrossRegionSupportStacks in CodePipeline which fixes #20334

Added unit tests for all three prop checks.

All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented May 19, 2022

@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p2 labels May 19, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team May 19, 2022 19:10
@tejasmr
Copy link
Contributor Author

tejasmr commented May 20, 2022

Can you review @NGL321 ?

@TheRealAmazonKendra TheRealAmazonKendra changed the base branch from v1-main to main June 2, 2022 09:15
@TheRealAmazonKendra TheRealAmazonKendra changed the title fix(pipelines): Missing prop check for reuseCrossRegionSupportStacks in CodePipeline fix(pipelines): reuseCrossRegionSupportStacks=true does not fail when existing pipeline is used Jul 13, 2022
Copy link
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@mergify
Copy link
Contributor

mergify bot commented Jul 14, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 1c6f3b2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 9c0ccca into aws:main Jul 14, 2022
@mergify
Copy link
Contributor

mergify bot commented Jul 14, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pipelines: Missing props unused check for CodePipeline
3 participants