pipelines: Missing props unused check for CodePipeline

[simonkarman]

Describe the bug

In the constructor of pipelines.CodePipeline checks are done to verify that pipelineName and crossAccountKeys are not set if a pipeline is already provided through the props. However this check is missing for the reuseCrossRegionSupportStacks property.

Expected Behavior

Providing both the reuseCrossRegionSupportStacks parameter and the codePipeline parameter to a pipelines.CodePipeline should fail.

Current Behavior

However, right now: Providing both the reuseCrossRegionSupportStacks parameter and the codePipeline parameter to a pipelines.CodePipeline does not fail, although it should.

Reproduction Steps

The following should fail.

    import { aws_codepipeline as cp, pipelines } from 'aws-cdk-lib';
    new pipelines.CodePipeline(scope, 'CodePipeline', {
      reuseCrossRegionSupportStacks: true,
      codePipeline: new cp.Pipeline(scope, 'Pipeline'),
      synth: new pipelines.ShellStep('Synth', { commands: ['ls'] }),
    });

Possible Solution

Add the following piece of code to line 357 of the CodePipeline.

      if (this.props.reuseCrossRegionSupportStacks !== undefined) {
        throw new Error('Cannot set \'reuseCrossRegionSupportStacks\' if an existing CodePipeline is given using \'codePipeline\'');
      }

Additional Information/Context

No response

CDK CLI Version

2.16.0 (build 4c77925)

Framework Version

No response

Node.js Version

v14.18.0

OS

MacOS

Language

Typescript

Language Version

3.9.7

Other information

No response

[NGL321]

Hey @simonkarman,

Thank you for reporting this! This seems like a simple fix, but it wont be high on the priority list (since even small fixes would require testing). Since you already have a good grasp on the solution, feel free to create a PR to resolve this following the Contribution guidelines and send it my way for review.
If you are unable to or don't have time, someone should address this eventually.

[simonkarman]

Thanks @NGL321! And it seems like @tezz-io beat me to it, thanks for the help!

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.