Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(apprunner): support VpcConnectors #19372

Closed
wants to merge 2 commits into from
Closed

feat(apprunner): support VpcConnectors #19372

wants to merge 2 commits into from

Conversation

DDynamic
Copy link
Contributor

@DDynamic DDynamic commented Mar 12, 2022 •
edited
Loading

closes #18887

  • Creates a new VpcConnector construct.
  • Make the app runner service construct accept a vpcConnector property. When present, associate the service with the connector.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Mar 12, 2022

@github-actions github-actions bot added the @aws-cdk/aws-apprunner Related to the apprunner package label Mar 12, 2022
@DDynamic DDynamic force-pushed the apprunner-vpc-connector branch 2 times, most recently from 0740683 to a7e6ed4 Compare March 13, 2022 06:43
@RichiCoder1
Copy link
Contributor

Considering how App Runner treats VPC Connectors, there's an argument that VPC Connector should it's own construct that's passed in (and therefore sharable) between App Runner services. Maybe still with the option for a service to implicitly create one for you.

@DDynamic DDynamic force-pushed the apprunner-vpc-connector branch 4 times, most recently from 7893f4f to a5b603b Compare March 15, 2022 02:16
@DDynamic
Copy link
Contributor Author

@RichiCoder1 makes sense. I have added the new construct accordingly.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 3dc362a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@github-actions
Copy link

This PR has been in the MERGE CONFLICTS state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@github-actions
Copy link

github-actions bot commented May 5, 2022

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@github-actions github-actions bot added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label May 5, 2022
@github-actions github-actions bot closed this May 5, 2022
@yamatatsu
Copy link
Contributor

@DDynamic Will this PR be revived?

@DDynamic
Copy link
Contributor Author

@yamatatsu I'll take a look shortly!

@DDynamic
Copy link
Contributor Author

New PR opened here: #20471

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@corymhall corymhall

Labels
@aws-cdk/aws-apprunner Related to the apprunner package closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(apprunner): apprunner vpc support
5 participants
@DDynamic @RichiCoder1 @aws-cdk-automation @yamatatsu @corymhall