Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(apprunner): apprunner vpc support #18887

Closed
1 of 2 tasks
RichiCoder1 opened this issue Feb 9, 2022 · 2 comments · Fixed by #20471
Closed
1 of 2 tasks

(apprunner): apprunner vpc support #18887

RichiCoder1 opened this issue Feb 9, 2022 · 2 comments · Fixed by #20471
Labels
@aws-cdk/aws-apprunner Related to the apprunner package effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@RichiCoder1
Copy link
Contributor

Description

Support for App Runner's recently introduced VPC support. https://aws.amazon.com/blogs/aws/new-for-app-runner-vpc-support/

Use Case

Support for talking to VPC-only services and private services. (RDS, ElastiCache, etc...)

Proposed Solution

Generating the new fields in the Cf L1 construct and adding VPC support to the L2 in a Lambda-like manner. E.g. Smartly taking VPC and optionally SGs and SubnetFilter, automatically adding the apprioriate IAM permissions.

Other information

No response

Acknowledge

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@RichiCoder1 RichiCoder1 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Feb 9, 2022
@github-actions github-actions bot added the @aws-cdk/aws-apprunner Related to the apprunner package label Feb 9, 2022
@corymhall corymhall added effort/medium Medium work item – several days of effort p2 and removed needs-triage This issue or PR still needs to be triaged. labels Feb 14, 2022
@corymhall
Copy link
Contributor

@RichiCoder1 it looks like the L1s will be added once #18930 is merged and then we can start on the L2 support.

@DDynamic DDynamic mentioned this issue Mar 12, 2022
Closed
@DDynamic DDynamic mentioned this issue May 24, 2022
Merged
4 tasks
@corymhall corymhall removed their assignment May 24, 2022
@mergify mergify bot closed this as completed in #20471 May 25, 2022
mergify bot pushed a commit that referenced this issue May 25, 2022
@DDynamic
feat(apprunner): VpcConnector construct (#20471)
5052191 
closes #18887

- Creates a new VpcConnector construct.
- Make the app runner service construct accept a `vpcConnector` property. When present, associate the service with the connector.

----

### All Submissions:

* [X] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [X] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
	* [X] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-apprunner Related to the apprunner package effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
2 participants
@RichiCoder1 @corymhall