Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove jsdom exclusion on yarn-upgrade #15005

Merged
merged 2 commits into from
Jun 7, 2021

Conversation

iliapolo
Copy link
Contributor

@iliapolo iliapolo commented Jun 6, 2021

No longer needed, and was actually blocking an upgrade to ws package that resolves https://github.com/aws/aws-cdk/security/dependabot/yarn.lock/ws/open

See feross/queue-microtask#17


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jun 6, 2021

@iliapolo iliapolo changed the title chore: remove jsdom exclusion chore: remove jsdom exclusion on yarn-upgrade Jun 6, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 6, 2021
@iliapolo iliapolo marked this pull request as ready for review June 6, 2021 19:11
@iliapolo iliapolo requested a review from a team June 7, 2021 08:45
@mergify
Copy link
Contributor

mergify bot commented Jun 7, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Jun 7, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: c2450ca
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@iliapolo iliapolo merged commit 6c7c7b5 into master Jun 7, 2021
@iliapolo iliapolo deleted the epolon/yarn-upgrade-remove-jsdom-exclusion branch June 7, 2021 10:27
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants