chore: remove jsdom exclusion on yarn-upgrade (#15005)

aws · Jun 7, 2021 · 6c7c7b5 · 6c7c7b5
1 parent bc01207
commit 6c7c7b5
Show file tree

Hide file tree

Showing 2 changed files with 277 additions and 384 deletions.
diff --git a/.github/workflows/yarn-upgrade.yml b/.github/workflows/yarn-upgrade.yml
@@ -63,12 +63,7 @@ jobs:
         run: yarn install
 
       - name: Run "yarn upgrade"
-        # jsdom breaks us starting from 16.5.1. Caused by https://github.com/feross/queue-microtask/issues/17
-        # in combination with https://github.com/jsdom/jsdom/commit/31eb938fdaa5d446e194c9ec4f0d6b46b4354954
-        # pinning this for now since its only used in tests (by jest-enviroment-jsdom).
-        # we are not even using this because our environment is 'node' - just the mere fact this module is loaded is what breaks.
-        # also - jest-enviroment-jsdom doesnt actually require 16.5.1 (https://github.com/facebook/jest/blob/master/packages/jest-environment-jsdom/package.json#L23)
-        run: yarn upgrade --pattern '!(jsdom)'
+        run: yarn upgrade
 
       # Next, create and upload the changes as a patch file. This will later be downloaded to create a pull request
       # Creating a pull request requires write permissions and it's best to keep write privileges isolated.