Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CHANGELOG to describe Rico's recent changes #109

Merged
merged 1 commit into from
Jun 15, 2018
Merged

Update CHANGELOG to describe Rico's recent changes #109

merged 1 commit into from
Jun 15, 2018

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Jun 15, 2018

By submitting this pull request, I confirm that my contribution is made under
the terms of the beta license.

@RomainMuller RomainMuller merged commit 0a78a17 into master Jun 15, 2018
@RomainMuller RomainMuller deleted the huijbers/update-changelog branch June 15, 2018 13:51
@eladb
Copy link
Contributor

eladb commented Jun 17, 2018

Nit picking on PR quality:

  • Not sure it makes sense for title to include your name :)
  • Description should be a bit more descriptive

@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
This was referenced Feb 24, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomainMuller RomainMuller RomainMuller approved these changes

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rix0rrr @eladb @RomainMuller @NGL321