Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-cdk-lib/aws_dynamodb: DynamoDB global tables should not use custom resource #24332

Closed
1 of 2 tasks
nakedible-p opened this issue Feb 25, 2023 · 3 comments
Closed
1 of 2 tasks

aws-cdk-lib/aws_dynamodb: DynamoDB global tables should not use custom resource #24332

nakedible-p opened this issue Feb 25, 2023 · 3 comments
Labels
@aws-cdk/aws-dynamodb Related to Amazon DynamoDB feature-request A feature should be added or improved. p1

Comments

@nakedible-p
Copy link
Contributor

Describe the feature

Not exactly a new feature, but an improvement to the current one.

  • In 2017, support was added for DynamoDB global tables via a separate module that "glues" tables together. This has since been deprecated and fully removed.
  • In 2019 this support was converted to use the new DynamoDB global tables by just specifying replicationRegions, and a custom resource is provisioned to set up the replication. There is no longer a separate class for replicated dynamodb table.
  • In 2021 support was added in CloudFormation to directly create DynamoDB global tables via the AWS::DynamoDB::GlobalTable. This was never added to CDK L2 constructs.
  • It is now 2023...

Please add L2 support for CfnGlobalTable separately, or modify the current L2 support to instead use CfnGlobalTable directly rather than adding custom resources to mimic the same functionality.

Use Case

I don't like additional custom resources than can break where "native" support is available. This seems to be just a remnant of the past.

Proposed Solution

Either add GlobalTable as a separate resource, or modify the current implementation of Table. It maybe hard to keep compatibility with a stable module if modifying the current implementation.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.66.0 (build c96c17d)

Environment details (OS name and version, etc.)

Linux codespaces-af5ba0 5.4.0-1103-azure #109~18.04.1-Ubuntu SMP Wed Jan 25 20:53:00 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
@nakedible-p nakedible-p added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Feb 25, 2023
@github-actions github-actions bot added the @aws-cdk/aws-dynamodb Related to Amazon DynamoDB label Feb 25, 2023
@pahud
Copy link
Contributor

pahud commented Mar 1, 2023

Yes we definitely should consider having a L2 for AWS::DynamoDB::GlobalTable. I am making this a p1 feature request and please help us prioritize with 👍.

@pahud pahud added p1 and removed needs-triage This issue or PR still needs to be triaged. labels Mar 1, 2023
@corymhall
Copy link
Contributor

We are tracking this through #16118

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@closesimple-wl closesimple-wl mentioned this issue Jul 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-dynamodb Related to Amazon DynamoDB feature-request A feature should be added or improved. p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pahud @nakedible-p @corymhall