Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-stepfunctions-tasks): SNS Publish Tasks do not include MessageGroupId for FIFO queues #27341

Closed
2 tasks
indrora opened this issue Sep 28, 2023 · 1 comment · Fixed by #27369
Closed
2 tasks

(aws-stepfunctions-tasks): SNS Publish Tasks do not include MessageGroupId for FIFO queues #27341

indrora opened this issue Sep 28, 2023 · 1 comment · Fixed by #27369
Labels
@aws-cdk/aws-stepfunctions-tasks feature/coverage-gap Gaps in CloudFormation coverage by L2 constructs feature-request A feature should be added or improved. p2

Comments

@indrora
Copy link
Contributor

indrora commented Sep 28, 2023

Describe the feature

Additional SQS Publish constructs targeted at the various shapes that an SQS publishing path can go.

Use Case

In situations where an SNS topic can be glued to a FIFO SQS queue, the MessageGroupId field needs to be included in the CloudFormation. This was discussed in #20280 and resolved through extending the L2 construct.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

na

Environment details (OS name and version, etc.)

na
@indrora indrora added p2 feature-request A feature should be added or improved. @aws-cdk/aws-stepfunctions-tasks feature/coverage-gap Gaps in CloudFormation coverage by L2 constructs labels Sep 28, 2023
@github-actions github-actions bot mentioned this issue Oct 1, 2023
Closed
@lpizzinidev lpizzinidev mentioned this issue Oct 1, 2023
Merged
mergify bot added a commit to lpizzinidev/aws-cdk that referenced this issue Oct 11, 2023
@mergify
Merge branch 'main' into awsgh-27341
b8b0cd3
@mergify mergify bot closed this as completed in #27369 Oct 11, 2023
mergify bot pushed a commit that referenced this issue Oct 11, 2023
@lpizzinidev
fix(stepfunctions-tasks): SNS FIFO tasks does not support messageGrou…
9cb9fb8 
…pId and messageDeduplicationId (#27369)

`SnsPublish` is failing the execution with FIFO topics due to some missing parameters.

This fixes the problem by adding:
* [`messageGroupId`](https://docs.aws.amazon.com/sns/latest/api/API_Publish.html#:~:text=Required%3A%20No-,MessageGroupId,-This%20parameter%20applies) - Required for FIFO topics
* [`messageDeduplicationId`](https://docs.aws.amazon.com/sns/latest/api/API_Publish.html#:~:text=Required%3A%20No-,MessageDeduplicationId,-This%20parameter%20applies) - Required for FIFO topics with [`contentBasedDeduplication`](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-sns-topic.html#cfn-sns-topic-contentbaseddeduplication) disabled

Closes #27341.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-stepfunctions-tasks feature/coverage-gap Gaps in CloudFormation coverage by L2 constructs feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
1 participant
@indrora