-
Notifications
You must be signed in to change notification settings - Fork 4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(stepfunctions-tasks): SNS FIFO tasks does not support messageGrou…
…pId and messageDeduplicationId (#27369) `SnsPublish` is failing the execution with FIFO topics due to some missing parameters. This fixes the problem by adding: * [`messageGroupId`](https://docs.aws.amazon.com/sns/latest/api/API_Publish.html#:~:text=Required%3A%20No-,MessageGroupId,-This%20parameter%20applies) - Required for FIFO topics * [`messageDeduplicationId`](https://docs.aws.amazon.com/sns/latest/api/API_Publish.html#:~:text=Required%3A%20No-,MessageDeduplicationId,-This%20parameter%20applies) - Required for FIFO topics with [`contentBasedDeduplication`](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-sns-topic.html#cfn-sns-topic-contentbaseddeduplication) disabled Closes #27341. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
- Loading branch information
1 parent
b1ce47b
commit 9cb9fb8
Showing
11 changed files
with
569 additions
and
59 deletions.
There are no files selected for viewing
6 changes: 3 additions & 3 deletions
6
.../test/sns/integ.publish.js.snapshot/aws-stepfunctions-tasks-sns-publish-integ.assets.json
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...g/framework-integ/test/aws-stepfunctions-tasks/test/sns/integ.publish.js.snapshot/cdk.out
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
2 changes: 1 addition & 1 deletion
2
...ramework-integ/test/aws-stepfunctions-tasks/test/sns/integ.publish.js.snapshot/integ.json
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
35 changes: 33 additions & 2 deletions
35
...ework-integ/test/aws-stepfunctions-tasks/test/sns/integ.publish.js.snapshot/manifest.json
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.