Added K8s example for header routing #193
Conversation
kiranmeduri
force-pushed
the
header-priority
branch
from
9b7cb72
to
abc3a5a
Compare
| exit 1 | ||
| fi | ||
|
|
||
| if [ -z "${MESH_NAME}" ]; then |
There was a problem hiding this comment.
Should this be EKS_CLUSTER not MESH_NAME?
There was a problem hiding this comment.
MESH_NAME is more appropriate given that this example should work outside of EKS, i.e. any K8s cluster
| for f in mesh app; do | ||
| eval "cat <<EOF | ||
| $(<${DIR}/${f}.yaml.template) | ||
| EOF" >${OUT_DIR}/${f}.yaml |
There was a problem hiding this comment.
You might use the envsubst program instead of the above use of eval:
for f in mesh app; do
envsubst <$DIR/$f.yaml.template >$DIR/$f.yaml
donehttps://www.gnu.org/software/gettext/manual/html_node/envsubst-Invocation.html
You'd want to export the vars used in the template, though.
There was a problem hiding this comment.
Don't I need to install gettext for this to work?
There was a problem hiding this comment.
Pretty sure envsubst is a standard utility on Linux at this point, but not a huge deal :)
There was a problem hiding this comment.
Not on my mac :(. Will leave it for now. Thanks for pointer.
kiranmeduri
force-pushed
the
header-priority
branch
2 times, most recently
from
7f91829
to
9afb817
Compare
kiranmeduri
force-pushed
the
header-priority
branch
from
9afb817
to
4d64e89
Compare
kiranmeduri
force-pushed
the
header-priority
branch
from
4d64e89
to
eda8475
Compare
Issue #, if available:
Description of changes:
Related to aws/aws-app-mesh-controller-for-k8s#56
Keeping in draft until controller change is released.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.