Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http-header match and priority to routes #56

Merged
merged 2 commits into from
Sep 12, 2019

Conversation

kiranmeduri
Copy link
Collaborator

Issue #, if available:

Description of changes:

  1. Added health-check for VirtualNode.Listener
  2. Add http-headers and priority support to Route.HttpRoute
  3. Update aws-sdk-go to v1.23.2

Testing Done:

  • Verified with local changes to aws-app-mesh-examples

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kiranmeduri kiranmeduri changed the title Update CRD and controller to support latest App Mesh features Add http-header match and priority to routes Aug 16, 2019
@kiranmeduri kiranmeduri force-pushed the header-priority branch 2 times, most recently from 8190bf2 to 3c9b639 Compare September 6, 2019 00:13
Copy link
Contributor

@nckturner nckturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update deploy/all.yaml? Or come up with a better process. Currently that file is referenced by the our install guide and the EKS docs. We could add a generation script, or modify both to reference each yaml file in deploy individually, or remove the individual files and only update all.yaml.

[email protected]

1. Added health-check for VirtualNode.Listener
2. Add http-headers and priority support to Route.HttpRoute
@kiranmeduri
Copy link
Collaborator Author

Can you update deploy/all.yaml?

Done

@kiranmeduri
Copy link
Collaborator Author

Currently that file is referenced by the our install guide and the EKS docs. We could add a generation script, or modify both to reference each yaml file in deploy individually, or remove the individual files and only update all.yaml.

To keep it simple, i think we can get rid of individual files in favor of all.yaml. Will follow up in a separate PR if that is ok.

@nckturner
Copy link
Contributor

Sounds good.

@nckturner nckturner merged commit 62f884d into aws:master Sep 12, 2019
@kiranmeduri kiranmeduri deleted the header-priority branch September 17, 2019 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants