Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated supported EC2 instance types #169

Merged
merged 1 commit into from
Jan 26, 2023
Merged

updated supported EC2 instance types #169

merged 1 commit into from
Jan 26, 2023

Conversation

haouc
Copy link
Contributor

@haouc haouc commented Jan 26, 2023

Issue #, if available:

Description of changes:
This PR is for update the supported EC2 instances information.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@haouc haouc requested a review from a team as a code owner January 26, 2023 19:47
Copy link
Contributor

@sushrk sushrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jdn5126
Copy link
Contributor

jdn5126 commented Jan 26, 2023

Is this supposed to be an exact copy of https://github.com/aws/amazon-vpc-cni-k8s/blob/master/pkg/awsutils/vpc_ip_resource_limit.go ? I noticed that there are some diffs, and I just merged in aws/amazon-vpc-cni-k8s#2235 to update the VPC CNI file

@haouc
Copy link
Contributor Author

haouc commented Jan 26, 2023

Is this supposed to be an exact copy of https://github.com/aws/amazon-vpc-cni-k8s/blob/master/pkg/awsutils/vpc_ip_resource_limit.go ? I noticed that there are some diffs, and I just merged in aws/amazon-vpc-cni-k8s#2235 to update the VPC CNI file

No they are different. This is for the resource controller to check if an instance supports trunk/branch interfaces during runtime.

@haouc haouc merged commit 5587b52 into aws:master Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants