Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run make generate-limits #2235

Merged
merged 2 commits into from
Jan 26, 2023
Merged

run make generate-limits #2235

merged 2 commits into from
Jan 26, 2023

Conversation

jdn5126
Copy link
Contributor

@jdn5126 jdn5126 commented Jan 25, 2023

What type of PR is this?
cleanup

Which issue does this PR fix:
#2228
#2206

What does this PR do / Why do we need it:
This PR runs make generate-limits to update instance networking limits. It is paired with awslabs/amazon-eks-ami#1153

If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
N/A

Testing done on this change:

% make generate-limits
go run  scripts/gen_vpc_ip_limits.go
2023-01-25 20:06:30.429784949 +0000 UTC m=+0.002784977 write error: can't make directories for new logfile: mkdir /host: permission denied
2023-01-25 20:06:30.429886219 +0000 UTC m=+0.002886241 write error: can't make directories for new logfile: mkdir /host: permission denied
{"level":"info","ts":"2023-01-25T20:06:30.538Z","caller":"/home/jdnelson/workplace/go/src/github.com/amazon-vpc-cni-k8s/scripts/gen_vpc_ip_limits.go:58","msg":"Describing instance types in region=ap-northeast-1"}
{"level":"info","ts":"2023-01-25T20:06:32.155Z","caller":"/home/jdnelson/workplace/go/src/github.com/amazon-vpc-cni-k8s/scripts/gen_vpc_ip_limits.go:58","msg":"Describing instance types in region=ap-northeast-2"}
{"level":"info","ts":"2023-01-25T20:06:33.525Z","caller":"/home/jdnelson/workplace/go/src/github.com/amazon-vpc-cni-k8s/scripts/gen_vpc_ip_limits.go:58","msg":"Describing instance types in region=ap-northeast-3"}
{"level":"info","ts":"2023-01-25T20:06:34.597Z","caller":"/home/jdnelson/workplace/go/src/github.com/amazon-vpc-cni-k8s/scripts/gen_vpc_ip_limits.go:58","msg":"Describing instance types in region=ap-south-1"}
{"level":"info","ts":"2023-01-25T20:06:36.725Z","caller":"/home/jdnelson/workplace/go/src/github.com/amazon-vpc-cni-k8s/scripts/gen_vpc_ip_limits.go:58","msg":"Describing instance types in region=ap-southeast-1"}
{"level":"info","ts":"2023-01-25T20:06:38.995Z","caller":"/home/jdnelson/workplace/go/src/github.com/amazon-vpc-cni-k8s/scripts/gen_vpc_ip_limits.go:58","msg":"Describing instance types in region=ap-southeast-2"}
{"level":"info","ts":"2023-01-25T20:06:40.944Z","caller":"/home/jdnelson/workplace/go/src/github.com/amazon-vpc-cni-k8s/scripts/gen_vpc_ip_limits.go:58","msg":"Describing instance types in region=ca-central-1"}
{"level":"info","ts":"2023-01-25T20:06:41.996Z","caller":"/home/jdnelson/workplace/go/src/github.com/amazon-vpc-cni-k8s/scripts/gen_vpc_ip_limits.go:58","msg":"Describing instance types in region=eu-central-1"}
{"level":"info","ts":"2023-01-25T20:06:44.289Z","caller":"/home/jdnelson/workplace/go/src/github.com/amazon-vpc-cni-k8s/scripts/gen_vpc_ip_limits.go:58","msg":"Describing instance types in region=eu-north-1"}
{"level":"info","ts":"2023-01-25T20:06:45.956Z","caller":"/home/jdnelson/workplace/go/src/github.com/amazon-vpc-cni-k8s/scripts/gen_vpc_ip_limits.go:58","msg":"Describing instance types in region=eu-west-1"}
{"level":"info","ts":"2023-01-25T20:06:48.059Z","caller":"/home/jdnelson/workplace/go/src/github.com/amazon-vpc-cni-k8s/scripts/gen_vpc_ip_limits.go:58","msg":"Describing instance types in region=eu-west-2"}
{"level":"info","ts":"2023-01-25T20:06:49.686Z","caller":"/home/jdnelson/workplace/go/src/github.com/amazon-vpc-cni-k8s/scripts/gen_vpc_ip_limits.go:58","msg":"Describing instance types in region=eu-west-3"}
{"level":"info","ts":"2023-01-25T20:06:51.300Z","caller":"/home/jdnelson/workplace/go/src/github.com/amazon-vpc-cni-k8s/scripts/gen_vpc_ip_limits.go:58","msg":"Describing instance types in region=sa-east-1"}
{"level":"info","ts":"2023-01-25T20:06:53.287Z","caller":"/home/jdnelson/workplace/go/src/github.com/amazon-vpc-cni-k8s/scripts/gen_vpc_ip_limits.go:58","msg":"Describing instance types in region=us-east-1"}
{"level":"info","ts":"2023-01-25T20:06:54.944Z","caller":"/home/jdnelson/workplace/go/src/github.com/amazon-vpc-cni-k8s/scripts/gen_vpc_ip_limits.go:58","msg":"Describing instance types in region=us-east-2"}
{"level":"info","ts":"2023-01-25T20:06:56.130Z","caller":"/home/jdnelson/workplace/go/src/github.com/amazon-vpc-cni-k8s/scripts/gen_vpc_ip_limits.go:58","msg":"Describing instance types in region=us-west-1"}
{"level":"info","ts":"2023-01-25T20:06:56.777Z","caller":"/home/jdnelson/workplace/go/src/github.com/amazon-vpc-cni-k8s/scripts/gen_vpc_ip_limits.go:58","msg":"Describing instance types in region=us-west-2"}
Adding "p4de.24xlarge": {15 50 unknown false} since it is missing from the API
Adding "c7g.metal": {15 50 unknown true} since it is missing from the API
Adding "cr1.8xlarge": {8 30 unknown false} since it is missing from the API
Adding "u-24tb1.metal": {15 50 unknown true} since it is missing from the API
Adding "u-9tb1.metal": {5 30 unknown true} since it is missing from the API
Adding "u-6tb1.metal": {5 30 unknown true} since it is missing from the API
Adding "c5a.metal": {15 50 unknown true} since it is missing from the API
Adding "c5ad.metal": {15 50 unknown true} since it is missing from the API
Adding "hs1.8xlarge": {8 30 unknown false} since it is missing from the API
Adding "u-12tb1.metal": {5 30 unknown true} since it is missing from the API
Adding "u-18tb1.metal": {15 50 unknown true} since it is missing from the API
{"level":"info","ts":"2023-01-25T20:06:57.565Z","caller":"/usr/lib/golang/src/runtime/proc.go:250","msg":"Generated pkg/awsutils/vpc_ip_resource_limit.go"}
{"level":"info","ts":"2023-01-25T20:06:57.568Z","caller":"/usr/lib/golang/src/runtime/proc.go:250","msg":"Generated misc/eni-max-pods.txt"}

Automation added to e2e:
N/A

Will this PR introduce any new dependencies?:
No

Will this break upgrades or downgrades. Has updating a running cluster been tested?:
N/A

Does this change require updates to the CNI daemonset config files to work?:
No

Does this PR introduce any user-facing change?:
Yes

Update instance type networking limits.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jdn5126 jdn5126 mentioned this pull request Jan 25, 2023
@jdn5126 jdn5126 merged commit d7447e8 into aws:master Jan 26, 2023
@jdn5126 jdn5126 deleted the pod_limits branch January 26, 2023 17:16
jdn5126 added a commit to jdn5126/amazon-vpc-cni-k8s that referenced this pull request Feb 8, 2023
jdn5126 added a commit that referenced this pull request Feb 8, 2023
* cherry-pick 2255

* cherry-pick #2235 and #2250
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants