Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve WARM_IP_TARGET handling #461

Merged
merged 11 commits into from
May 15, 2019
Merged

Improve WARM_IP_TARGET handling #461

merged 11 commits into from
May 15, 2019

Conversation

mogren
Copy link
Contributor

@mogren mogren commented May 10, 2019

Issue #, if available: #377, #294, #314, #391, #265 and others.

Description of changes:
Merge of all fixes that has gone into the 1.4 branch back into master. Add support for actually freeing unused IPs from an attached ENI. Requires the ec2:UnassignPrivateIPs permission.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mogren mogren added bug enhancement feature request priority/P0 Highest priority. Someone needs to actively work on this. labels May 10, 2019
@mogren mogren added this to the v1.5 milestone May 10, 2019
@mogren mogren requested a review from vsiddharth May 15, 2019 18:15
Copy link
Contributor

@vsiddharth vsiddharth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add more context to the description in the PR?

Provided initial set of comments.

ipamd/ipamd.go Show resolved Hide resolved
ipamd/ipamd.go Outdated Show resolved Hide resolved
ipamd/ipamd.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug enhancement feature request priority/P0 Highest priority. Someone needs to actively work on this.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants