Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor directory is out of date #466

Closed
bboreham opened this issue May 12, 2019 · 2 comments
Closed

vendor directory is out of date #466

bboreham opened this issue May 12, 2019 · 2 comments

Comments

@bboreham
Copy link
Contributor

For instance the code has a dependency on github.com/deckarep/golang-set, but this is not in the vendor directory.

Maybe the intention is that everyone should download dependencies via go mod and the vendor directory should be deleted from the repo?

@mogren
Copy link
Contributor

mogren commented May 14, 2019

That dependency will be added by #461 once it has been merged, but I think you are right, we should probably rely on go mod for this.

@mogren
Copy link
Contributor

mogren commented May 16, 2019

Updated the vendor folder. That said, building in docker uses go mod, I'll update the Readme for #465.

@mogren mogren closed this as completed May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants