-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(idempotency): ability to specify JMESPath custom functions #3150
feat(idempotency): ability to specify JMESPath custom functions #3150
Conversation
Hey @arnabrahman, thank you for the PR! Before I get into the review, I wanted to ask if you're still seeing the issue with coverage on the git hooks described here #3134. I've tried reproducing it on my side and I can't. |
Yesterday, when I was pushing the commits, I faced the coverage issue again. After that, for all subsequent commits, I used the skip flag, as far as I remember. Another thing, I believe my main branch was behind when I encountered this issue. After merging the main branch, I don’t recall if I tried committing without the skip flag. I’ll try again and get back to you @dreamorosi |
Nope, the test coverage error is not there anymore. |
Thank you @arnabrahman - I'm still going to do a small adjustment to the git hook because right now they're trying to run also e2e tests, which we don't want to. Next time that it happens, if you can, please try to remove this flag I'll review the PR in the next couple hrs tops. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding this feature, I appreciate your time and effort on this.
I have run the e2e tests on this branch and they are successful.
Summary
According to the Issue description, customers should be able to send their custom JMESPatch functions instead of built-in ones using the idempotency utility.
Changes
jmesPathOptions
inIdempotencyOptions
Functions
to use it type thejmesPathOptions
Issue number: #2368
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.