Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance: vitest coverage misreporting #3134

Closed
1 of 2 tasks
dreamorosi opened this issue Sep 30, 2024 · 2 comments
Closed
1 of 2 tasks

Maintenance: vitest coverage misreporting #3134

dreamorosi opened this issue Sep 30, 2024 · 2 comments
Labels
internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) rejected This is something we will not be working on. At least, not in the measurable future tests PRs that add or change tests

Comments

@dreamorosi
Copy link
Contributor

Summary

While working on #3133, @arnabrahman reported that the test coverage within packages that have been migrated to vitest varies depending on how you run the test command.

We should look into the issue and understand why it's happening and how to fix it. See here for more details.

Why is this needed?

So that we can have the same 100% coverage reporting regardless of the context of the tests.

Which area does this relate to?

Tests

Solution

No response

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.
@dreamorosi dreamorosi added internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) discussing The issue needs to be discussed, elaborated, or refined tests PRs that add or change tests labels Sep 30, 2024
This was referenced Sep 30, 2024
Merged
Merged
@dreamorosi dreamorosi added rejected This is something we will not be working on. At least, not in the measurable future and removed discussing The issue needs to be discussed, elaborated, or refined labels Oct 11, 2024
@dreamorosi dreamorosi moved this from Triage to Closed in Powertools for AWS Lambda (TypeScript) Oct 11, 2024
@dreamorosi
Copy link
Contributor Author

As discussed in #3150 the issue seems to have been transient and no longer present, potentially because of a stale branch.

I'll close this for now, and we can reopen if the issue reappears, potentially with steps to reproduce it consistently.

@dreamorosi dreamorosi closed this as not planned Won't fix, can't repro, duplicate, stale Oct 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) rejected This is something we will not be working on. At least, not in the measurable future tests PRs that add or change tests
Projects
Powertools for AWS Lambda (TypeScript)
Status: Closed
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dreamorosi