Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(logger): revisit Logger unit tests #1339

Merged
merged 6 commits into from
Feb 26, 2023
Merged

tests(logger): revisit Logger unit tests #1339

merged 6 commits into from
Feb 26, 2023

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

This PR refactors some of the unit tests for Logger as well as applying consistent spacing/naming and simplifying some of the test cases and names. The functionalities and types of tests haven't been changed.

Once merged this PR closes #1332.

How to verify this change

See checks below this PR.

Related issues, RFCs

Issue number: #1332

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding changes to the examples
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dreamorosi dreamorosi self-assigned this Feb 26, 2023
@pull-request-size pull-request-size bot added the size/XL PRs between 500-999 LOC, often PRs that grown with feedback label Feb 26, 2023
@dreamorosi dreamorosi added logger This item relates to the Logger Utility tests PRs that add or change tests labels Feb 26, 2023
@dreamorosi dreamorosi merged commit 907a1f0 into main Feb 26, 2023
@dreamorosi dreamorosi deleted the 1332-maintenance-revisit-logger-unitt-tests branch February 26, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dreamorosi dreamorosi

Labels
logger This item relates to the Logger Utility size/XL PRs between 500-999 LOC, often PRs that grown with feedback tests PRs that add or change tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maintenance: revisit Logger unit tests
1 participant
@dreamorosi