Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance: revisit Logger unit tests #1332

Closed
1 of 2 tasks
dreamorosi opened this issue Feb 26, 2023 · 1 comment · Fixed by #1339
Closed
1 of 2 tasks

Maintenance: revisit Logger unit tests #1332

dreamorosi opened this issue Feb 26, 2023 · 1 comment · Fixed by #1339
Assignees
@dreamorosi
Labels
completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) logger This item relates to the Logger Utility tests PRs that add or change tests

Comments

@dreamorosi
Copy link
Contributor

Summary

The unit tests for the Logger are particularly verbose and after an initial review there is a potential to simplify some parts. This issue tracks this activity.

Why is this needed?

To keep the tests maintainable and up to date with the practices in the other utilities.

Which area does this relate to?

Tests, Logger

Solution

No response

Acknowledgment
@dreamorosi dreamorosi added logger This item relates to the Logger Utility internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) confirmed The scope is clear, ready for implementation tests PRs that add or change tests labels Feb 26, 2023
@dreamorosi dreamorosi self-assigned this Feb 26, 2023
@dreamorosi dreamorosi moved this from Backlog to Working on it in AWS Lambda Powertools for TypeScript Feb 26, 2023
@dreamorosi dreamorosi mentioned this issue Feb 26, 2023
Merged
13 tasks
@github-project-automation github-project-automation bot moved this from Working on it to Coming soon in AWS Lambda Powertools for TypeScript Feb 26, 2023
@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added the pending-release This item has been merged and will be released soon label Feb 26, 2023
@dreamorosi dreamorosi added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon confirmed The scope is clear, ready for implementation labels Feb 26, 2023
@dreamorosi dreamorosi moved this from Coming soon to Shipped in AWS Lambda Powertools for TypeScript Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dreamorosi dreamorosi

Labels
completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) logger This item relates to the Logger Utility tests PRs that add or change tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests(logger): revisit Logger unit tests aws-powertools/powertools-lambda-typescript
1 participant
@dreamorosi