refactor(typing): reduce aws_lambda_powertools.shared.types usage #4896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in aws-powertools#4607. This simplifies linting and refactoring so we can introduce from __future__ import annotations to all files, which is the plan as the next step.
pull-request-size
bot
added
the
size/L
2 tasks
|
Reviewing now. |
boring-cyborg
bot
added
the
documentation
|
leandrodamascena
requested changes
Aug 6, 2024
There was a problem hiding this comment.
Hey @ericbn I did some changes here.
- I fixed the documentation, some highlights were wrong because we changed imports.
- I removed JSONType from shared and moved it to Feature Flags, makes more sense.
- I fixed absolute imports in Feature Flags - unrelated, but always good.
Can you please take a look before we approve and merge?
|
Oi @leandrodamascena. All looking good to me. Good catch on the absolute imports and good to know about |
leandrodamascena
approved these changes
Aug 6, 2024
|
Olá :D |
github-actions
bot
added
enhancement
and removed
documentation
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #4897
Summary
Changes
Reduce
aws_lambda_powertools.shared.typesusage. The goal was to remove the package as a whole, but the customAnyCallableTandJSONTypedefined there cannot be replaced by any type provided in typing or typing_extensions.User experience
As discussed in #4607, this is an intermediary step towards adding
from __future__ import annotationsto all files. The refactoring in this PR will help ruff better help us refactor the code once we introduce the TCH and UP rules as discussed in the main issue.Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.