Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech debt: Remove usages of aws_lambda_powertools.shared.types #4897

Closed
1 of 2 tasks
leandrodamascena opened this issue Aug 6, 2024 · 2 comments · Fixed by #4896
Closed
1 of 2 tasks

Tech debt: Remove usages of aws_lambda_powertools.shared.types #4897

leandrodamascena opened this issue Aug 6, 2024 · 2 comments · Fixed by #4896
Assignees
@leandrodamascena
Labels
tech-debt Technical Debt tasks typing Static typing definition related issues (mypy, pyright, etc.)
Milestone
Powertools v3 (pr...

Comments

@leandrodamascena
Copy link
Contributor

Why is this needed?

Remove usages of aws_lambda_powertools.shared.types imports and replace them by either types from the standard library that are already compatible with Python >= 3.8 or types from typing_extensions. Remove the aws_lambda_powertools.shared.types package too.

Which area does this relate to?

Other

Suggestion

No response

Acknowledgment
@leandrodamascena leandrodamascena added triage Pending triage from maintainers tech-debt Technical Debt tasks labels Aug 6, 2024
@leandrodamascena leandrodamascena moved this from Triage to Working on it in Powertools for AWS Lambda (Python) Aug 6, 2024
@leandrodamascena leandrodamascena self-assigned this Aug 6, 2024
@leandrodamascena leandrodamascena added typing Static typing definition related issues (mypy, pyright, etc.) and removed triage Pending triage from maintainers labels Aug 6, 2024
@leandrodamascena leandrodamascena mentioned this issue Aug 6, 2024
Merged
7 tasks
@leandrodamascena leandrodamascena linked a pull request Aug 6, 2024 that will close this issue
refactor(typing): reduce aws_lambda_powertools.shared.types usage #4896
Merged
7 tasks
@leandrodamascena
Copy link
Contributor Author

Closed via #4896

@github-project-automation github-project-automation bot moved this from Working on it to Coming soon in Powertools for AWS Lambda (Python) Aug 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2024

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leandrodamascena leandrodamascena

Labels
tech-debt Technical Debt tasks typing Static typing definition related issues (mypy, pyright, etc.)
Projects
Powertools for AWS Lambda (Python)
Status: Coming soon
Milestone
Powertools v3 (priority)
Development

Successfully merging a pull request may close this issue.

refactor(typing): reduce aws_lambda_powertools.shared.types usage ericbn/powertools-lambda-python
1 participant
@leandrodamascena