Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use success() condition in the soak workflow #345

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Use success() condition in the soak workflow #345

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2bf68c6
Use terraform version in the soak workflow
vasireddy99 Nov 8, 2022
a70d1ce
Use Success() condition in the soak workflow
vasireddy99 Nov 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/soaking.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,8 @@ jobs:
echo TERRAFORM_DIRECTORY=${{ matrix.language }}/integration-tests/${{ matrix.sample-app }}/${{ matrix.instrumentation-type }} |
tee --append $GITHUB_ENV
- uses: hashicorp/setup-terraform@v2
with:
terraform_version: 1.3.1
- name: Initialize terraform
run: terraform init
working-directory: ${{ env.TERRAFORM_DIRECTORY }}
Expand Down Expand Up @@ -251,7 +253,7 @@ jobs:
-a ${{ matrix.architecture }}
- name: Set output if layer Soak Tests has error
id: set-layer-if-error-output
if: ${{ failure() }}
if: ${{ success() }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the official documentation for success() existing? I have found the docs for failure().

Also, can you expand why this change is necessary? From what I can see this step only needs to happen if a previous step fails, not if it is successful.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, found the docs for success() here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah added the description for it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would we want to run echo "::set-output name=${{ matrix.language }}-${{ matrix.instrumentation-type }}-error::FAILED" if the previous steps were successful?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think i could improve this PR.

run: echo "::set-output name=${{ matrix.language }}-${{ matrix.instrumentation-type }}-error::FAILED"
- name: Remove sdk layers from terraform management to prevent deletion.
if: ${{ matrix.language != 'go' }}
Expand Down