Use success() condition in the soak workflow #345
Conversation
| @@ -251,7 +253,7 @@ jobs: | |||
| -a ${{ matrix.architecture }} | |||
| - name: Set output if layer Soak Tests has error | |||
| id: set-layer-if-error-output | |||
| if: ${{ failure() }} | |||
| if: ${{ success() }} | |||
There was a problem hiding this comment.
Where is the official documentation for success() existing? I have found the docs for failure().
Also, can you expand why this change is necessary? From what I can see this step only needs to happen if a previous step fails, not if it is successful.
There was a problem hiding this comment.
Nevermind, found the docs for success() here.
There was a problem hiding this comment.
yeah added the description for it.
There was a problem hiding this comment.
Why would we want to run echo "::set-output name=${{ matrix.language }}-${{ matrix.instrumentation-type }}-error::FAILED" if the previous steps were successful?
There was a problem hiding this comment.
Think i could improve this PR.
|
This PR is stale because it has been open 60 days with no activity. |
|
This PR is stale because it has been open 60 days with no activity. |
|
This PR is stale because it has been open 60 days with no activity. |
Description:
This PR is created to use success()s instead of failure(). The reason for this change is that it is not necessary to check the ancestors jobs, which would lead not getting o/p layer ARNeven when succeed in re-runs.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.