-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update addons to latest supported versions #1096
Conversation
global: | ||
grafana: | ||
enabled: false | ||
proxy: false | ||
|
||
imageVersion: prod-1.96.0 | ||
imageVersion: prod-1.97.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you take the hardcoded versions out of the values.yaml
file and have it managed by the helm version like the other yaml files? That way we can easily upgrade
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor comments and question, also, let's make sure to run some e2e for sanity check.
Thank you!
namespace = local.namespace | ||
timeout = 1200 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My brain is telling me there's a reason why we set this timeout to be longer than the default, @askulkarni2 may know better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the helm-addon already defaults to this so its redundant here
timeout = try(var.helm_config["timeout"], 1200) |
namespace = "kube-system" | ||
timeout = "1200" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as argo, I want to say there's a reason why we increased the timeout for specific addons, but I also remember there were times where the addons were trying to be deployed before nodes were even provisioned.
we need to keep an eye to see if we'll get reports of failed apply's due to addons timeouts (argo/albc)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default already for helm-addon
timeout = try(var.helm_config["timeout"], 1200) |
chart = local.name | ||
repository = "https://aws.github.io/eks-charts" | ||
version = "0.0.3" | ||
namespace = kubernetes_namespace_v1.csi_secrets_store_provider_aws.metadata[0].name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good change using implicit dependency instead of using depends_on
@@ -1,4 +1,4 @@ | |||
output "argocd_gitops_config" { | |||
description = "Configuration used for managing the add-on with ArgoCD" | |||
value = var.manage_via_gitops ? local.argocd_gitops_config : null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we want to show all the other gitops config there are?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you elaborate a bit more? This is all that was behind the local variable https://github.com/aws-ia/terraform-aws-eks-blueprints/pull/1096/files/b838d60698d590d25936fa3747b6817ccb9cd5d7#diff-646886bed0c86a54e6455e85bc6760a1674984bbe88fea71bc7758044df75844L24-L26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, I read this wrong, I expected to see more dynamic configuration but it's local that mostly have enable=true and in some cases the service account name.
all tests pass save for the usual suspect failures https://github.com/aws-ia/terraform-aws-eks-blueprints/actions/runs/3348792340/jobs/5548211087 |
What does this PR do?
tflint
to current version and correct linting warnings (mostly around use of*
)Motivation
More
pre-commit run -a
with this PRNote: Not all the PRs require a new example and/or doc page. In general:
docs/add-ons/*
is required for new a new addonFor Moderators
Additional Notes