-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Refactor examples to leverage terraform-aws-eks
for cluster creation
#1074
Conversation
@@ -178,40 +111,6 @@ module "eks_blueprints_kubernetes_addons" { | |||
] | |||
} | |||
|
|||
enable_fargate_fluentbit = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved to fargate-serverless
589d874
to
b9638b4
Compare
failed plans will fail since those are removed or re-named |
… into refactor/example-clusters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a big one! LGTM, some minor comments and questions here.
Let's make sure to run the e2e across the examples and do some sanity checks to all the running resources per example, feel free to pull me in so we can divide and conquer this.
@@ -344,13 +333,11 @@ module "vpc" { | |||
default_security_group_tags = { Name = "${local.name}-default" } | |||
|
|||
public_subnet_tags = { | |||
"kubernetes.io/cluster/${local.name}" = "shared" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't that needed for automatic subnet discovery by LBs or ingress controllers? or since in this example we don't use any then we can safely remove
… into refactor/example-clusters
ffec553
to
b0eb963
Compare
…fore provisioning addons, CI is clean before provisioning
switching to draft to split up PR |
… into refactor/example-clusters
… into refactor/example-clusters
16fdd9f
to
5c762e6
Compare
5c762e6
to
1929952
Compare
What does this PR do?
terraform-aws-eks
for cluster creationterraform-aws-modules
Motivation
More
pre-commit run -a
with this PRNote: Not all the PRs require a new example and/or doc page. In general:
docs/add-ons/*
is required for new a new addonFor Moderators
Additional Notes