Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add linux job user override tests #477

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

YutongLi291
Copy link
Contributor

@YutongLi291 YutongLi291 commented Nov 14, 2024

What was the problem/requirement? (What/Why)

Users are able to boot up the linux worker agent with custom job override users rather than using the default job-user. This will make sure that jobs are ran with the custom overridden user.

We should make sure this functionality works as expected and there are no regressions.

What was the solution? (How)

Add WA E2E test cases that verify that the job user can be overridden through the config or the env variable on Linux

What is the impact of this change?

Prevention of regressions in functionality allowing customers to override the job user.

How was this change tested?

# Linux
source .e2e_linux_infra.sh
hatch run e2e-test

# Windows
source .e2e_windows_infra.sh
hatch run e2e-test

31 passed, 6 skipped, 5 warnings in 3099.93s (0:51:39)
Tested over 10 times to verify that it is not flaky.

Was this change documented?

No

Is this a breaking change?

No

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@YutongLi291 YutongLi291 requested a review from a team as a code owner November 14, 2024 04:06
@YutongLi291 YutongLi291 enabled auto-merge (squash) November 14, 2024 20:07
test/e2e/conftest.py Outdated Show resolved Hide resolved
test/e2e/test_override_job_user.py Outdated Show resolved Hide resolved
test/e2e/test_override_job_user.py Outdated Show resolved Hide resolved
test/e2e/test_override_job_user.py Outdated Show resolved Hide resolved
@YutongLi291 YutongLi291 merged commit 0a4e65b into aws-deadline:mainline Nov 15, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants