test: add worker log writing to local disk test #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Li <[email protected]>
leongdl
approved these changes
Nov 15, 2024
leongdl
reviewed
Nov 15, 2024
| check_session_log_exists_result.exit_code == 0 | ||
| ) # The -e command returns 0 on linux if the file does exist | ||
|
|
||
| # Check that the session log file is not accessible by the job user |
There was a problem hiding this comment.
Super nit of nits job user extra space!
leongdl
reviewed
Nov 15, 2024
| ) | ||
| assert ( | ||
| check_session_log_exists_result.exit_code == 0 | ||
| ) # The -e command returns 0 on linux if the file does exist |
There was a problem hiding this comment.
Super nit of nits does exist extra space!
benl-2023
approved these changes
Nov 18, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #477 to be merged first due to conftest additions.
What was the problem/requirement? (What/Why)
When jobs are ran with worker agent, the worker writes the session log, worker log, and worker bootstrap logs to the disk on the worker instance (with the default options if the worker logs aren't manually turned off).
We should verify that these logs are written, accessible by the worker user, and not accessible by the job user and prevent regressions in the future.
What was the solution? (How)
Add a test that verifies that worker will write these files to disk, and that they're accessible by the worker user, and not accessible by the job user.
What is the impact of this change?
Better testing to verify that worker and session logs are written to disk by the worker
How was this change tested?
Was this change documented?
No
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.