fix: Resolve menu.py not found error when installing via pip #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steven Banaszak <[email protected]>
StevenBanaszak
force-pushed
the
mainline
branch
from
24a5928 to
2f36a08
Compare
|
crowecawcaw
reviewed
Nov 14, 2024
Comment on lines
+97
to
+103
| <fnAddPathEnvironmentVariable> | ||
| <progressText>Setting NUKE_PATH</progressText> | ||
| <name>NUKE_PATH</name> | ||
| <value>${nuke_installdir}:${nuke_installdir}/deadline/nuke_submitter</value> | ||
| <scope>${installscope}</scope> | ||
| <insertAt>end</insertAt> | ||
| </fnAddPathEnvironmentVariable> |
There was a problem hiding this comment.
How does this work on Macs? Does it add the env var to the bash profile?
There was a problem hiding this comment.
How does this work on Macs? Does it add the env var to the bash profile?
Does the installer even support MacOS?
There was a problem hiding this comment.
This is a custom action that we have defined. The bulk of the work uses setInstallerVariable from InstallBuilder https://releases.installbuilder.com/installbuilder/docs/installbuilder-userguide/variables.html
The installer does not support MacOS. You can use pip install for Macs, though.
crowecawcaw
approved these changes
Nov 14, 2024
joshueng
approved these changes
Nov 14, 2024
Merged
StevenBanaszak
added a commit
to StevenBanaszak/deadline-cloud-for-nuke
that referenced
this pull request
Nov 26, 2024
…aws-deadline#172)" This reverts commit 9364964.
StevenBanaszak
added a commit
to StevenBanaszak/deadline-cloud-for-nuke
that referenced
this pull request
Nov 26, 2024
…aws-deadline#172)" This reverts commit 9364964. Signed-off-by: Steven Banaszak <[email protected]>
StevenBanaszak
added a commit
that referenced
this pull request
Nov 26, 2024
…#172)" (#175) This reverts commit 9364964. Signed-off-by: Steven Banaszak <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
Addressing user feedback on receiving doesn't have menu.py error while installing deadline-cloud-for-nuke using
pip install deadline-cloud-for-nuke -tin MacOS.This pull request is effectively un-reverting a change that was previously reverted in this pull request. Updates have been made to the installer to ensure that it still works as expected.
What was the solution? (How)
What is the impact of this change?
pip install deadline-cloud-for-nuke -tworks.How was this change tested?
pip install /Users/sbanas/dev/deadline-clients/deadline-cloud-for-nuke/dist/deadline_cloud_for_nuke-0.18.5-py3-none-any.whl -t ~/testingDid you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.
Was this change documented?
Yes
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.