Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: Resolve menu.py not found error when running pip install… #170

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

StevenBanaszak
Copy link
Contributor

… deadline-cloud-for-nuke -t (#165)"

This reverts commit 82b7eb2.

What was the problem/requirement? (What/Why)

The submitter installer was broken by this change. This was due to menu.py not being in the correct place.

What was the solution? (How)

Revert the commit.

What is the impact of this change?

The submitter installer will work again.

How was this change tested?

  1. Run the adapter with a default config NUKE_ADAPTOR_NUKE_EXECUTABLE=/Applications/Nuke15.0v4/Nuke15.0v4.app/Contents/MacOS/Nuke15.0 nuke-openjd run --init-data file:///Users/sbanas/dev/deadline-clients/deadline-cloud-for-nuke/init-data.yaml --run-data file:///Users/sbanas/dev/deadline-clients/deadline-cloud-for-nuke/run-data.yaml
  2. Run the previous command but with a stock config (in this case I used aces_1.2)
  3. Run the adapter with an env variable config OCIO=/Applications/Nuke15.0v4/Nuke15.0v4.app/Contents/Resources/OCIOConfigs/configs/aces_1.2/config.ocio NUKE_ADAPTOR_NUKE_EXECUTABLE=/Applications/Nuke15.0v4/Nuke15.0v4.app/Contents/MacOS/Nuke15.0 nuke-openjd run --init-data file:///Users/sbanas/dev/deadline-clients/deadline-cloud-for-nuke/init-data.yaml --run-data file:///Users/sbanas/dev/deadline-clients/deadline-cloud-for-nuke/run-data.yaml
  4. Run the submitter with the default config. Verify that the job succeeds.
  5. Run the submitter with a stock config. Verify that the job succeeds.
  6. Run the submitter with the env config. Verify that the job succeeds.

Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.


Timestamp: 2024-10-20T14:48:44.570850-07:00
Running job bundle output test: /Users/sbanas/dev/deadline-clients/deadline-cloud-for-nuke/job_bundle_output_tests/group-read

group-read
Test succeeded

Timestamp: 2024-10-20T14:48:45.405362-07:00
Running job bundle output test: /Users/sbanas/dev/deadline-clients/deadline-cloud-for-nuke/job_bundle_output_tests/noise-saver

noise-saver
Test succeeded

Timestamp: 2024-10-20T14:48:46.153780-07:00
Running job bundle output test: /Users/sbanas/dev/deadline-clients/deadline-cloud-for-nuke/job_bundle_output_tests/multi-load-save

multi-load-save
Test succeeded

Timestamp: 2024-10-20T14:48:46.911392-07:00
Running job bundle output test: /Users/sbanas/dev/deadline-clients/deadline-cloud-for-nuke/job_bundle_output_tests/frame

frame
Test succeeded

Timestamp: 2024-10-20T14:48:47.637687-07:00
Running job bundle output test: /Users/sbanas/dev/deadline-clients/deadline-cloud-for-nuke/job_bundle_output_tests/ocio

ocio
Test succeeded

Timestamp: 2024-10-20T14:48:48.354727-07:00
Running job bundle output test: /Users/sbanas/dev/deadline-clients/deadline-cloud-for-nuke/job_bundle_output_tests/cwd-path

cwd-path
Test succeeded

All tests passed, ran 6 total.
Timestamp: 2024-10-20T14:48:52.359785-07:00

Was this change documented?

No

Is this a breaking change?

No


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@StevenBanaszak StevenBanaszak requested a review from a team as a code owner October 20, 2024 22:03
"",
)

except BaseException:

Check notice

Code scanning / CodeQL

Except block handles 'BaseException' Note

Except block directly handles BaseException.
…stall deadline-cloud-for-nuke -t <folder> (#165)"

This reverts commit 82b7eb2.

Signed-off-by: Steven Banaszak <[email protected]>
Copy link

@StevenBanaszak StevenBanaszak merged commit 71b8c8b into aws-deadline:mainline Oct 21, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants