Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves concurrency with MQTT in AWSIoT #4211

Merged
merged 6 commits into from
Jul 15, 2022
Merged

Conversation

brennanMKE
Copy link
Contributor

Issue #, if available:

#4210

Description of changes:

Replaced semaphores with queues to handle serial behavior.

Check points:

  • Added new tests to cover change, if needed
  • All unit tests pass
  • All integration tests pass
  • Updated CHANGELOG.md
  • Documentation update for the change if required
  • PR title conforms to conventional commit style

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@brennanMKE brennanMKE self-assigned this Jul 15, 2022
@brennanMKE brennanMKE merged commit b9d5fbf into main Jul 15, 2022
@brennanMKE brennanMKE deleted the stehlib.mqtt-concurrency branch July 15, 2022 17:12
@brennanMKE brennanMKE changed the title Improves concurrent with MQTT in AWSIoT Improves concurrency with MQTT in AWSIoT Jul 15, 2022
@brennanMKE brennanMKE added the concurrency Issues with concurrency problems label Jul 15, 2022
samkudr pushed a commit to samkudr/aws-sdk-ios that referenced this pull request Sep 26, 2022
* eliminates Dispatch Semaphore
* moves work which mutates state into private functions which are only run on a serial queue
* adds assertions to ensure work is on the right queue
* replaces semaphore with queue in AWSMQTTEncoder, AWSMQTTSession and AWSIoTMQTTClient
gabek pushed a commit to KeepSafe/aws-sdk-ios that referenced this pull request Aug 31, 2023
* eliminates Dispatch Semaphore
* moves work which mutates state into private functions which are only run on a serial queue
* adds assertions to ensure work is on the right queue
* replaces semaphore with queue in AWSMQTTEncoder, AWSMQTTSession and AWSIoTMQTTClient
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
concurrency Issues with concurrency problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants