fix(iot): increment mqtt encoder semaphore value on dealloc #4185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#2016
Description of changes:
_encodeSemaphore
inAWSMQTTEncoder
is created withdispatch_semaphore_create(1)
. When_encodeSemaphore
is released (AWSMQTTEncoder
dealloc'd) with a value of 0, a crash occurs due to the value being less than the original value (1).Here's where the crash is occurring in libdispatch.
This change increments the
_encodeSemphore
value viadispatch_semaphore_signal(self.encodeSemaphore);
indealloc
ofAWSMQTTEncoder
.Check points:
Added new tests to cover change, if neededAll integration tests passDocumentation update for the change if requiredBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.