fix(@aws-amplify/auth): CodeDeliveryDetails return type for Auth.resendSignUp #6561
Conversation
| @@ -98,7 +98,7 @@ declare module 'amazon-cognito-identity-js' { | |||
| callback: IAuthenticationCallback | |||
| ): void; | |||
| public resendConfirmationCode( | |||
| callback: NodeCallback<Error, 'SUCCESS'>, | |||
| callback: NodeCallback<Error, any>, | |||
There was a problem hiding this comment.
Could we be more specific with this?
There was a problem hiding this comment.
Not without inspecting the payload:
https://github.com/aws-amplify/amplify-js/pull/5112/files#r396791471
Also, this PR can't successfully be updated to the latest branch via GitHub's GUI for some reason. We may be better off closing this in favor of: #5112.
(I was attempting to pull in the author's latest code, but unsuccessfully)
|
Closing in favor of #5112 |
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Issue #, if available:
Fixes #5029 & adds to #5112 to replace
anywithCodeDeliveryDetailsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.